Skip to content

fix for knuckle_hinge using both in_place and knuckle_clearance#1881

Merged
adrianVmariano merged 2 commits intoBelfrySCAD:masterfrom
pelletjl:knuckle_hinge
Jan 15, 2026
Merged

fix for knuckle_hinge using both in_place and knuckle_clearance#1881
adrianVmariano merged 2 commits intoBelfrySCAD:masterfrom
pelletjl:knuckle_hinge

Conversation

@pelletjl
Copy link
Contributor

fixes #1878 for default (untagged) case

@adrianVmariano
Copy link
Collaborator

Can't you use default_tag() to do this?

@pelletjl
Copy link
Contributor Author

I was trying to narrow the scope of when the default tag is applied just in case there were any unknown side effects, but I can try using default_tag() instead.

@pelletjl
Copy link
Contributor Author

Ah, I see how to use default_tag() to do the same thing now. The documentation for it wasn't clear.

@adrianVmariano
Copy link
Collaborator

The hinge still has a problem as shown by top_half(z=4.8):

image

Some extra material is connecting the two sides of the hinge together.

@pelletjl
Copy link
Contributor Author

That part is from the extra backstop that I added. It goes away without the second (attached) child, which I've adjusted in my design.

@adrianVmariano
Copy link
Collaborator

Would it suffice to clarify default_tag if I changed the description to "conditionally set a default tag"?

@pelletjl
Copy link
Contributor Author

pelletjl commented Jan 15, 2026

The description was fine, I just didn't see the argument in the module signature (in the usage section) even though it was in the argument descriptions. But if you're in there doing other things and wanted to update the description, it wouldn't hurt.

@adrianVmariano
Copy link
Collaborator

I can update the docs and the update will merge someday.

@adrianVmariano adrianVmariano merged commit c528d98 into BelfrySCAD:master Jan 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] knuckle_hinge: knuckle_clearance prevents in_place hinges from working

2 participants